[asterisk-dev] [Code Review] VERBOSE message shows up on console when 'debug' enabled in logger.conf

[Russell Bryant]

> On 2010-09-13 12:53:16, Russell Bryant wrote:
> > /branches/1.8/main/logger.c, lines 885-894
> > <https://reviewboard.asterisk.org/r/915/diff/3/?file=12493#file12493line885>
> >
> >     I wonder why VERBOSE and DTMF are pulled out specifically to not include the file/function/line number.  I would find that information useful on _every_ message, personally.  This isn't related to your patch, though.
> 
> Brett Bryant wrote:
>     Would you like me to do that here? It'd certainly be a quick change. Your call.

Go ahead and make the change while you're in here.


> On 2010-09-13 12:53:16, Russell Bryant wrote:
> > /branches/1.8/main/logger.c, line 1314
> > <https://reviewboard.asterisk.org/r/915/diff/3/?file=12493#file12493line1314>
> >
> >     The previous code skipped the first character.  That character is now being passed into ast_log(), but I don't see it accounted for anywhere.  It's a bit tricky because we *do* want to send that character out to the verbosers, but not to the log files.
> 
> Brett Bryant wrote:
>     I have a fix for that, ill update it when I get home.

Sounds good.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/915/#review2715
-----------------------------------------------------------


On 2010-09-12 22:49:36, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/915/
> -----------------------------------------------------------
> 
> (Updated 2010-09-12 22:49:36)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch fixes an issue where calling ast_verbose would place formatted verbose messages to the console when it wasn't supposed to.
> 
> 
> This addresses bug 17974.
>     https://issues.asterisk.org/view.php?id=17974
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/logger.c 286375 
> 
> Diff: https://reviewboard.asterisk.org/r/915/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brett
> 
>