[asterisk-dev] [Code Review] Add parking extension for non-default parking lots
Russell Bryant
russell at digium.com
Mon Sep 13 15:52:24 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/884/#review2719
-----------------------------------------------------------
/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/884/#comment5887>
I think you should still pass chan, as well. There is a possibility that pbx_find_extension() will block for a while, so autoservice is needed.
- Russell
On 2010-09-13 15:27:14, Jeff Peeler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/884/
> -----------------------------------------------------------
>
> (Updated 2010-09-13 15:27:14)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> I think the summary says all here, this was just something that wasn't implemented when multiparking was added.
>
>
> This addresses bug 14882.
> https://issues.asterisk.org/view.php?id=14882
>
>
> Diffs
> -----
>
> /trunk/CHANGES 286473
> /trunk/channels/chan_dahdi.c 286473
> /trunk/channels/chan_iax2.c 286473
> /trunk/channels/chan_mgcp.c 286473
> /trunk/channels/chan_sip.c 286473
> /trunk/channels/sig_analog.c 286473
> /trunk/channels/sip/include/sip.h 286473
> /trunk/configs/features.conf.sample 286473
> /trunk/include/asterisk/features.h 286473
> /trunk/main/features.c 286473
>
> Diff: https://reviewboard.asterisk.org/r/884/diff
>
>
> Testing
> -------
>
> I tested as I went and ran all of our parking tests.
>
>
> Thanks,
>
> Jeff
>
>
More information about the asterisk-dev
mailing list