[asterisk-dev] [Code Review] Merging events for Exchange web service doesn't work as expected, resulting in only one event in calendar

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/916/#review2713
-----------------------------------------------------------

Ship it!


With the format string change, it looks good to me. Thanks.


/branches/1.8/res/res_calendar_ews.c
<https://reviewboard.asterisk.org/r/916/#comment5867>

    Since this is now unsigned, the format should be "%u".



/branches/1.8/res/res_calendar_ews.c
<https://reviewboard.asterisk.org/r/916/#comment5868>

    If ao2_container_count() returns a negative, this would break. But, I don't think that is ever supposed to happen--so it should be safe.


- Terry


On 2010-09-11 14:52:05, Pitel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/916/
> -----------------------------------------------------------
> 
> (Updated 2010-09-11 14:52:05)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> See the bug
> 
> 
> This addresses bug 0017877.
>     https://issues.asterisk.org/view.php?id=0017877
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/res/res_calendar_ews.c 286371 
> 
> Diff: https://reviewboard.asterisk.org/r/916/diff
> 
> 
> Testing
> -------
> 
> We are already using it in my company.
> 
> 
> Thanks,
> 
> Pitel
> 
>