[asterisk-dev] [Code Review] Make sure that we handle possible format error in ast_openstream_full() - channel.c

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/911/#review2702
-----------------------------------------------------------

Ship it!



/branches/1.4/main/file.c
<https://reviewboard.asterisk.org/r/911/#comment5854>

    My only other suggestion would be to add a LOG_WARNING here (if ast_set_write_format() doesn't do that already).  It still might make sense to have one that makes it clear that the file playback has failed.


- Russell


On 2010-09-08 13:02:59, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/911/
> -----------------------------------------------------------
> 
> (Updated 2010-09-08 13:02:59)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> We don't handle errors when we can't set a format that the sound file is available in on the current channel. We should. I fix.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/file.c 285265 
> 
> Diff: https://reviewboard.asterisk.org/r/911/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olle E
> 
>