[asterisk-dev] [Code Review] Add parking extension for non-default parking lots

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/884/#review2684
-----------------------------------------------------------



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/884/#comment5839>

    Are you sure that storing off this channel pointer and sending it off to another thread is safe?



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/884/#comment5840>

    I still don't think this is quite right.  Actually I think you can remove the ao2_callback completely.  If the extension you find is the Park application, then you know you're good to go.


- Russell


On 2010-09-03 18:01:24, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/884/
> -----------------------------------------------------------
> 
> (Updated 2010-09-03 18:01:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I think the summary says all here, this was just something that wasn't implemented when multiparking was added.
> 
> 
> This addresses bug 14882.
>     https://issues.asterisk.org/view.php?id=14882
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 285008 
>   /trunk/channels/chan_dahdi.c 285008 
>   /trunk/channels/chan_iax2.c 285008 
>   /trunk/channels/chan_mgcp.c 285008 
>   /trunk/channels/chan_sip.c 285008 
>   /trunk/channels/sig_analog.c 285008 
>   /trunk/channels/sip/include/sip.h 285008 
>   /trunk/configs/features.conf.sample 285008 
>   /trunk/include/asterisk/features.h 285008 
>   /trunk/main/features.c 285008 
> 
> Diff: https://reviewboard.asterisk.org/r/884/diff
> 
> 
> Testing
> -------
> 
> I tested as I went and ran all of our parking tests.
> 
> 
> Thanks,
> 
> Jeff
> 
>