[asterisk-dev] [Code Review] handle_request_subscribe is too slow cause of iterating through all sip dialogs

[sst at sil.at]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/901/#review2678
-----------------------------------------------------------


atleast my linksys spa962 handle it as described in the RFC:
SIP Response message for INCOMING dialog NOTIFY arrived

<--- SIP read from UDP:PHONE-IP:5062 --->
SIP/2.0 481 Call Leg/Transaction Does Not Exist

but it looks like asterisk then didnt delete this subscription matching to this call-id, i will have a look at this.
btw the notify for the second subscribe works fine and do what it should do.

- schmidts


On 2010-09-03 07:08:29, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/901/
> -----------------------------------------------------------
> 
> (Updated 2010-09-03 07:08:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> in chan_sip.c the handle_request_subscribe function is very slow cause of iterating through all sip dialogs on every subscribe, to find old subscribes from this peer to exten at context. This patch will disable this iteration cause its not necessary.
> 
> 
> Diffs
> -----
> 
>   branches/1.6.2/channels/chan_sip.c 284848 
> 
> Diff: https://reviewboard.asterisk.org/r/901/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> schmidts
> 
>