[asterisk-dev] [Code Review] handle_request_subscribe is too slow cause of iterating through all sip dialogs

[Russell Bryant]

> On 2010-09-03 07:23:58, Russell Bryant wrote:
> > Wow, I'm surprised this code was in there.  I agree - make it go away!

Actually, hold off on commit.  After talking to David Vossel about this, I think we need to get to the bottom of why this was put there in the first place to be sure it should be removed.  The code was added very intentionally in revision 7514:

r7513 | kpfleming | 2005-12-16 21:44:30 -0600 (Fri, 16 Dec 2005) | 2 lines

forcibly expire previous subscriptions from a peer when they resubscribe (keeps them from building up and waiting for expiration, and stops us sending unwanted NOTIFY messages to devices)


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/901/#review2662
-----------------------------------------------------------


On 2010-09-03 07:08:29, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/901/
> -----------------------------------------------------------
> 
> (Updated 2010-09-03 07:08:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> in chan_sip.c the handle_request_subscribe function is very slow cause of iterating through all sip dialogs on every subscribe, to find old subscribes from this peer to exten at context. This patch will disable this iteration cause its not necessary.
> 
> 
> Diffs
> -----
> 
>   branches/1.6.2/channels/chan_sip.c 284848 
> 
> Diff: https://reviewboard.asterisk.org/r/901/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> schmidts
> 
>