[asterisk-dev] [Code Review] New testsuite test for call files and pbx_spool

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/906/#review2667
-----------------------------------------------------------



/testsuite/tests/pbx/call-files/run-test
<https://reviewboard.asterisk.org/r/906/#comment5828>

    Since these are constants, make them ALL_CAPS



/testsuite/tests/pbx/call-files/run-test
<https://reviewboard.asterisk.org/r/906/#comment5827>

    I still don't quite understand why a lock is needed here.  I think the reactor is single threaded, so it shouldn't be possible for this function to run more than once at a time.



/testsuite/tests/pbx/call-files/test-config.yaml
<https://reviewboard.asterisk.org/r/906/#comment5829>

    What about this test doesn't work with Asterisk 1.4?  Perhaps minversion can just be changed to '1.4' ?


- Russell


On 2010-09-03 10:27:41, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/906/
> -----------------------------------------------------------
> 
> (Updated 2010-09-03 10:27:41)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test runs two call files through asterisk to ensure that both call files connecting extensions, and call files connecting applications both work properly.
> 
> 
> Diffs
> -----
> 
>   /testsuite/tests/pbx/call-files/configs/extensions.conf PRE-CREATION 
>   /testsuite/tests/pbx/call-files/run-test PRE-CREATION 
>   /testsuite/tests/pbx/call-files/sample.call PRE-CREATION 
>   /testsuite/tests/pbx/call-files/sample2.call PRE-CREATION 
>   /testsuite/tests/pbx/call-files/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/906/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brett
> 
>