[asterisk-dev] dahdi_device representation

[Shaun Ruffell]

On 08/30/2010 06:45 PM, Oron Peled wrote:
> I've looked into your "chan_list" git branch (yes, Tzafrir pushed me
> to do it...) and happily discovered it contains a huge ammount
> of important code cleanup (refactoring ioctl()'s into functions, using
> temporary "chan" variables, etc.)
> 
> My suggestion is to push all code refactoring/cleanups ASAP to DAHDI
> trunk/ (just like the dahdi_span_ops re-org). That way, while we
> evaluate alternative channel mappings, our diffs will not be
> littered with pile of ugly old code.

I've removed the span_list that I had at the base of the chan_list (at
Tzafrir's request) and pushed just what I believe are non-controversial
cleanups to
http://github.com/sruffell/dahdi-linux/commits/chan_list_refactoring and
http://svn.asterisk.org/svn/dahdi/linux/team/sruffell/chan_list_refactoring.
 I've done some basic tests with digital spans and pseudo conferences
and didn't see any breakage but rather slight performance improvements.

I'm having a bit of a problem with reviewboard, but I'll check again if
someone replies and says they want to use that interface for reviewing
just this group of changes.

The series (from revision 9255 through 9293) starts at:
http://lists.digium.com/pipermail/dahdi-commits/2010-September/002427.html

-- 
Shaun Ruffell
Digium, Inc. | Linux Kernel Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org