[asterisk-dev] [Code Review] Document CONNECTEDLINE and REDIRECTING useage.

Wed Sep 1 17:56:06 CDT 2010

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 4
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line4>
> >
> >     Instead of "party information" maybe "party identification" ...?  or "party ID information" ?

done

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 5
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line5>
> >
> >     There isn't another document that might delve into this that you could point to is there?

Made more explicit that it is the sample configuration files.

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 106
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line106>
> >
> >     At first I thought this might have been a typo for COLP, but since I don't know enough about this I googled for it.
> >     
> >     I think this is a good opportunity to define it. Earlier in this chapter you used COLP, so it should also be defined the first time you use it:
> >     
> >     Connected Line Identification Restriction (COLR)
> >     
> >     Connected Line Identification Presentation (COLP)
> >     
> >     Note: if you search for COLP, the first hit I get is for Joshua Colp's twitter account :)

Done

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 13
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line13>
> >
> >     hmmm, is there a table we could use here instead?
> >     
> >     http://en.wikibooks.org/wiki/LaTeX/Tables

This is more definition than table data.

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 32
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line32>
> >
> >     We should probably have some sort of introduction here. Something like, "Asterisk contains several tools for manipulating the party identification for a call. Additional information can be found by using the 'core show function' or 'core show application' console commands as the Asterisk CLI. The following table shows some of the more common tools for manipulating the party identification."
> >     
> >     Whatever you used in the introduction you can use here re: "party identification".

Used your paragraph with some slight modifications.

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 34
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line34>
> >
> >     Most of these itemized lists could probably be converted to tables, so I'll stop pointing it out each time I see it.

Why would it be better as a table instead of a bullet list?

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 49
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line49>
> >
> >     s/it's/its

Done

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 50
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line50>
> >
> >     s/You use it/CALLERID can be used/
> >     
> >     s/possibly//

done

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 52
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line52>
> >
> >     s/dial/Dial()/
> >     s/queue/Queue()/
> >     
> >

done

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 94
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line94>
> >
> >     This is a good spot for an itemized list :)

Itemized

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 97
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line97>
> >
> >     s/dial/Dial()/  ?

done

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 120
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line120>
> >
> >     s/The/In the dialplan applications Dial() and Queue(), the/

done

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 145
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line145>
> >
> >     Table?

no, chair

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 169
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line169>
> >
> >     Ideally we should have an introduction here too:
> >     
> >     
> >     "The following examples show several common scenarios in which you may need to manipulate caller party identification from the dialplan."
> >     
> >     You could add some more to that probably.

added

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 174
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line174>
> >
> >     You can choose to make this change or not, but in the 3rd edition of Asterisk:TFoT we're writing dialplan in this format:
> >     
> >     
> >     exten => 1000,1,Verbose(1,Simple recording playback example)
> >        same => n,Set(...)
> >        same => n,Set(...)
> >     
> >     You may or may not wish to update the examples to match that formatting.

I'll leave it alone.  Running out of time in the day for it.

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 171
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line171>
> >
> >     I like these examples! Perhaps you could briefly explain each of them stating what the purpose is, and when you might use it?

The subsection name already gives a hint of when you might use it.  Also there are comments in the sample dialplans.

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 245
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line245>
> >
> >     Introduction suggested.
> >     
> >     "The following is a list of ideas in which the manipulation of party identification would be beneficial."
> >     
> >     etc...

done

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 247
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line247>
> >
> >     Perhaps you could give a hint for each of the items of what tools you might use, or which example to look at?

bah humbug

> On 2010-09-01 11:48:18, Leif Madsen wrote:
> > /trunk/doc/tex/partymanip.tex, line 274
> > <https://reviewboard.asterisk.org/r/875/diff/1/?file=12295#file12295line274>
> >
> >     After this you could add a conclusion which maybe directs users to various websites which contains additional information about some of the concepts implemented here?

Other than the ISDN standards or SIP RFC's I don't know where else to direct the reader.

- rmudgett

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/875/#review2650
-----------------------------------------------------------

On 2010-08-24 19:11:07, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/875/
> -----------------------------------------------------------
> 
> (Updated 2010-08-24 19:11:07)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> 
> This addresses bug 17808.
>     https://issues.asterisk.org/view.php?id=17808
> 
> 
> Diffs
> -----
> 
>   /trunk/doc/tex/asterisk.tex 283524 
>   /trunk/doc/tex/channelvariables.tex 283524 
>   /trunk/doc/tex/partymanip.tex PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/875/diff
> 
> 
> Testing
> -------
> 
> Generated asterisk.pdf without errors and did not find any TeX goofs.
> 
> 
> Thanks,
> 
> rmudgett
> 
>