[asterisk-dev] [Code Review] The faxdetect option in chan_dahdi only works for the first FAX call.

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/972/
-----------------------------------------------------------

(Updated 2010-10-13 15:19:06.273277)


Review request for Asterisk Developers and Russell Bryant.


Summary (updated)
-------

The chan_dahdi faxdetect option only works for the first call.  After that 
the option no longer works.  The struct dahdi_pvt.callprogress member is 
the encoded user config setting for the callprogress and faxdetect config 
options.  Changing this value alters the configuration for all following 
calls until the chan_dahdi.conf file is reloaded.  

* Fixed the chan_dahdi ast_channel_setoption callback to not change the 
users faxdetect config setting except for the current call.  

* Fixed the chan_dahdi ast_channel_queryoption callback to read the active 
DSP setting of the faxdetect option.  

* Made actually disable the active faxdetect DSP setting for the current 
call on the analog port.  my_handle_dtmfup() is used for normal analog 
ports.  dahdi_handle_dtmfup() is the legacy code and is no longer used 
unless in a radio mode.  


This addresses bug 18116.
    https://issues.asterisk.org/view.php?id=18116


Diffs
-----

  /branches/1.8/channels/chan_dahdi.c 291540 

Diff: https://reviewboard.asterisk.org/r/972/diff


Testing
-------

Compile and code inspection testing.


Thanks,

rmudgett