[asterisk-dev] [Code Review] adding CLI function sip show dialogs

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/966/#review2826
-----------------------------------------------------------

Ship it!


Looks good to me with after these small changes.


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/966/#comment6013>

    reverse preprocessor logic to have smaller block at top:
    #ifndef AST_DEVMODE
    ...
    #else
    ...
    ...
    ...
    #endif



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/966/#comment6012>

    spacing around equals



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/966/#comment6014>

    Here and below, shouldn't this be passing flags instead of just 0?


- Jeff


On 2010-10-06 04:02:22, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/966/
> -----------------------------------------------------------
> 
> (Updated 2010-10-06 04:02:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Using sip show objects to check sip dialogs is not very usefull and blocks the peer container unnecessary.
> 
> i have written this function sip show dialogs which checks the three container where dialogs could be included and just print them out.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 290305 
> 
> Diff: https://reviewboard.asterisk.org/r/966/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> schmidts
> 
>