[asterisk-dev] [Code Review] Have fastagi pass DTMF before starting tests

Paul Belanger reviewboard at asterisk.org
Wed Nov 24 08:15:34 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1035/
-----------------------------------------------------------

Review request for Asterisk Developers and Erin Spiceland.


Summary
-------

The current fastagi tests are dependent on the speed of the host computer, on a slow system they will usually fail. The 2nd reactor has not full started but the 1st has already started the test.  I've now added 2-way communication between the dialplans.  Since side A starts first, we now WaitExten(10) expecting side B to send DTMF (it confirms B is ready).

I also noticed we don't properly stop reactor A, which was an issue on the FreeBSD host.  It basically created a deadlock on 'core stop now', eventually the testsuite had to kill the process to stop asterisk.


Diffs
-----

  asterisk/trunk/tests/fastagi/configs/extensions.conf 930 
  asterisk/trunk/tests/fastagi/connect/run-test 930 
  asterisk/trunk/tests/fastagi/control-stream-file/run-test 930 
  asterisk/trunk/tests/fastagi/database/run-test 930 
  asterisk/trunk/tests/fastagi/execute/run-test 930 
  asterisk/trunk/tests/fastagi/get-data/run-test 930 
  asterisk/trunk/tests/fastagi/hangup/run-test 930 
  asterisk/trunk/tests/fastagi/record-file/run-test 930 
  asterisk/trunk/tests/fastagi/say-alpha/run-test 930 
  asterisk/trunk/tests/fastagi/say-date/run-test 930 
  asterisk/trunk/tests/fastagi/say-datetime/run-test 930 
  asterisk/trunk/tests/fastagi/say-digits/run-test 930 
  asterisk/trunk/tests/fastagi/say-number/run-test 930 
  asterisk/trunk/tests/fastagi/say-phonetic/run-test 930 
  asterisk/trunk/tests/fastagi/say-time/run-test 930 
  asterisk/trunk/tests/fastagi/stream-file/run-test 930 

Diff: https://reviewboard.asterisk.org/r/1035/diff


Testing
-------

local testing and on slower freebsd box.


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101124/aae925da/attachment.htm 


More information about the asterisk-dev mailing list