[asterisk-dev] [Code Review] Swedish saynumber (again :-) ) - correctly say thousands and millions

Olle E Johansson reviewboard at asterisk.org
Tue Nov 23 09:13:00 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1033/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

After fixing saynumber(1,n) this morning we went on testing and realized that we now don't say 1101 and 10001001 correctly. This change fixes that. 

For Swedes and Abba lovers:

- "En tusen en hundra en" is not correct for saynumber(1101,N). "Ett tusen ett hundra en" is better.


This addresses bug 18355.
    https://issues.asterisk.org/view.php?id=18355


Diffs
-----

  /branches/1.4/main/say.c 295906 

Diff: https://reviewboard.asterisk.org/r/1033/diff


Testing
-------

In front of 25 people that acted as judges when we played 45 different numbers that we thought where good test cases. All people where Swedish and everyone accepted the changes.


Thanks,

Olle E

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101123/8448b87f/attachment.htm 


More information about the asterisk-dev mailing list