[asterisk-dev] [Code Review] MeetMe option for caching join/leave announce names

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1009/#review2957
-----------------------------------------------------------


This is close.  The biggest thing that needs some final touchup is the documentation part.


/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6184>

    Have you looked to see what this looks like when you do "core show application MeetMe" ?  I think it's still missing information that explains the argument to h().  It needs to explain the mailbox[@context] part.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6185>

    remove space after (, add space before {



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6182>

    there is a whitespace problem here



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6183>

    space after comma



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6186>

    This can be simplified to check 3 flags at once.


- Russell


On 2010-11-17 15:53:09, Andrew Parisio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1009/
> -----------------------------------------------------------
> 
> (Updated 2010-11-17 15:53:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I was looking for a feature to cache the recording of your name for when you use options I or i in meetme that announces a users name on entering and exiting a conference, this way users wouldn’t have to do this every time. My goal with this is to auto-join members to a conference without them having to enter a pin or say their name, yet still have their name announced to the conference.  Instead of caching the file we use the users voicemail greet file from their mailbox, if the file does not exist then we unset the new flag in meetme (h), and it falls back to the old switches of i or I depending what you'd prefer for recording review/noreview.
> 
> Usage is like this: MeetMe(PIN,h(${CALLERID(num)}@default))
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 294817 
> 
> Diff: https://reviewboard.asterisk.org/r/1009/diff
> 
> 
> Testing
> -------
> 
> I've tested with the users voicemail greet file there, and not there, with a combination of flags i or I being set.  
> I tested that i and I work properly without h set to ensure nothing i've added broke the old functionality.
> 
> I tested using the following commands with the greeting file being in the users mailbox, and the greeting file not being there.
> MeetMe(1,ih(${CALLERID(num)}@default))
> MeetMe(1,Ih(${CALLERID(num)}@default))
> MeetMe(1,i)
> MeetMe(1,I)
> 
> 
> Thanks,
> 
> Andrew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101121/ef5fc640/attachment-0001.htm