[asterisk-dev] [Code Review] Announce to user that they have been muted when muting is done via AMI

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1010/#review2951
-----------------------------------------------------------


The addition of the destructor looks correct to me.  None of the code you have added seems to affect reference counts in any way, so I don't see anything wrong that you caused.  If that function is not getting called, then that sounds like there is a memory leak there that was there already.  The destructor gets called when the reference count hits 0.

- Russell


On 2010-11-20 15:03:19, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1010/
> -----------------------------------------------------------
> 
> (Updated 2010-11-20 15:03:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Announce to user that they have been muted when muting is done via AMI
> 
> When a user does a *1, they hear 'you have been (un)muted'
> When a mute or unmute command is sent over the ami, the user hears no mute notification.
> 
> I'm not sure if my method of handling stopping/resuming music on hold is correct.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_meetme.c 295123 
> 
> Diff: https://reviewboard.asterisk.org/r/1010/diff
> 
> 
> Testing
> -------
> 
> AMI MeetmeMute
> AMI MeetmeUnmute
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101121/a50ca19f/attachment.htm