[asterisk-dev] [Code Review] Only install asterisk and samples once, not each test.

Paul Belanger reviewboard at asterisk.org
Fri Nov 19 13:10:53 CST 2010



> On 2010-11-19 13:06:07, Russell Bryant wrote:
> > In practice, all of the tests are running sandboxed Asterisk instances, so I think this change makes sense.  However, this change makes that a requirement.  I'd like the README to reflect that.
> > 
> > If we do this, how about we just remove it from runtests.py all together?  That would sure make the people that run it on systems with configs they don't want to lose very happy.  :-)
> >

I'm fine with removing this from runtests.py.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1024/#review2949
-----------------------------------------------------------


On 2010-11-19 11:56:00, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1024/
> -----------------------------------------------------------
> 
> (Updated 2010-11-19 11:56:00)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Trivial patch to move the install / samples logic from running each test to only executed once.  A future patch we rework this logic into a sandbox, not the root filesystem.
> 
> This will help improve IO performance
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/runtests.py 871 
> 
> Diff: https://reviewboard.asterisk.org/r/1024/diff
> 
> 
> Testing
> -------
> 
> Local testing.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101119/59c01c1a/attachment.htm 


More information about the asterisk-dev mailing list