[asterisk-dev] [Code Review] Update tests to use install_configs() and create a default logger.conf

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1022/#review2947
-----------------------------------------------------------

Ship it!


Looks good.  The only other thing I'd like to see is some notes about this in the README that talks about how to write tests.

- Russell


On 2010-11-19 08:39:41, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1022/
> -----------------------------------------------------------
> 
> (Updated 2010-11-19 08:39:41)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently each test defines their logger.conf ability, making logging inconsistence across all tests.  With this path I'm proposing we define a default logger.conf the testsuite will use.  If tests require additional logger settings, simply create a 'logger.conf.inc' file which will be included by 'logger.conf'
> 
> By default we will set:
> 
> 1.4 / 1.6.2
> [logfiles]
> console => notice,warning,error
> full => notice,warning,error,debug,verbose
> --
> 1.8+
> [logfiles]
> console => notice,warning,error
> full => *
> --
> 
> Having 'console =>' only display 'notice,warning,error' will help with keeping bamboo output clean.  Any debugging / verbose / fax / etc will be redirected to 'full =>'.  If a test creator requires additional control, they should use 'messages =>'.
> 
> A future patch will standardize the debug and verbose levels, again giving the test creator the ability to override then via the CLI.
> 
> Additional convert tests to use 'install_configs()'.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 860 
>   asterisk/trunk/tests/cdr/cdr_unanswered_yes/configs/logger.conf 860 
>   asterisk/trunk/tests/cdr/cdr_unanswered_yes/run-test 860 
>   asterisk/trunk/tests/cdr/cdr_userfield/configs/logger.conf 860 
>   asterisk/trunk/tests/cdr/cdr_userfield/run-test 860 
>   asterisk/trunk/tests/cdr/console_dial_sip_answer/configs_common/logger.conf 860 
>   asterisk/trunk/tests/cdr/console_dial_sip_answer/run-test 860 
>   asterisk/trunk/tests/cdr/console_dial_sip_busy/configs_common/logger.conf 860 
>   asterisk/trunk/tests/cdr/console_dial_sip_busy/run-test 860 
>   asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs_common/logger.conf 860 
>   asterisk/trunk/tests/cdr/console_dial_sip_congestion/run-test 860 
>   asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs_common/logger.conf 860 
>   asterisk/trunk/tests/cdr/console_dial_sip_transfer/run-test 860 
>   asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs_common/logger.conf 860 
>   asterisk/trunk/tests/cdr/console_fork_after_busy_forward/run-test 860 
>   asterisk/trunk/tests/cdr/console_fork_before_dial/configs_common/logger.conf 860 
>   asterisk/trunk/tests/cdr/console_fork_before_dial/run-test 860 
>   asterisk/trunk/tests/cdr/nocdr/configs/logger.conf 860 
>   asterisk/trunk/tests/cdr/nocdr/run-test 860 
>   asterisk/trunk/tests/chanspy/chanspy_barge/run-test 860 
>   asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/run-test 860 
>   asterisk/trunk/tests/configs/branch-1.4/logger.conf PRE-CREATION 
>   asterisk/trunk/tests/configs/branch-1.6.2/logger.conf PRE-CREATION 
>   asterisk/trunk/tests/configs/logger.conf PRE-CREATION 
>   asterisk/trunk/tests/configs/logger.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/directed_pickup/run-test 860 
>   asterisk/trunk/tests/fastagi/configs/logger.conf 860 
>   asterisk/trunk/tests/feature_attended_transfer/configs/logger.conf 860 
>   asterisk/trunk/tests/feature_attended_transfer/configs2/logger.conf 860 
>   asterisk/trunk/tests/feature_attended_transfer/run-test 860 
>   asterisk/trunk/tests/feature_blonde_transfer/run-test 860 
>   asterisk/trunk/tests/iax2/basic-call/configs/logger.conf 860 
>   asterisk/trunk/tests/iax2/basic-call/configs2/logger.conf 860 
>   asterisk/trunk/tests/manager/event-monitor/configs/logger.conf 860 
>   asterisk/trunk/tests/manager/event-monitor/run-test 860 
>   asterisk/trunk/tests/manager/login/configs/logger.conf 860 
>   asterisk/trunk/tests/manager/login/run-test 860 
>   asterisk/trunk/tests/mixmonitor/run-test 860 
>   asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test 860 
>   asterisk/trunk/tests/pbx/call-files/run-test 860 
>   asterisk/trunk/tests/sip_attended_transfer/run-test 860 
>   asterisk/trunk/tests/sip_attended_transfer_tcp/run-test 860 
>   asterisk/trunk/tests/sip_attended_transfer_v6/run-test 860 
>   asterisk/trunk/tests/sip_one_legged_transfer/run-test 860 
>   asterisk/trunk/tests/sip_one_legged_transfer_v6/run-test 860 
>   asterisk/trunk/tests/udptl/configs1/logger.conf 860 
>   asterisk/trunk/tests/udptl/configs2/logger.conf 860 
>   asterisk/trunk/tests/udptl/run-test 860 
>   asterisk/trunk/tests/udptl_v6/configs1/logger.conf 860 
>   asterisk/trunk/tests/udptl_v6/configs2/logger.conf 860 
>   asterisk/trunk/tests/udptl_v6/run-test 860 
> 
> Diff: https://reviewboard.asterisk.org/r/1022/diff
> 
> 
> Testing
> -------
> 
> Local system, all tests passed.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101119/0441bf88/attachment-0001.htm