[asterisk-dev] [Code Review] Add Path header support to chan_sip

[Olle E Johansson]

> On 2010-10-29 14:06:32, Klaus Darilion wrote:
> > /branches/1.8/channels/chan_sip.c, line 4364
> > <https://reviewboard.asterisk.org/r/991/diff/1/?file=12766#file12766line4364>
> >
> >     How does realtime work? How do I defined the fields which should be saved/read from DB?

It's basically a name=value concept, much like the configurations. Just add a field. The important part here is that we need an option on whether to have Path support in realtime or not, otherwise you are forcing EVERYONE to change their database tables.


> On 2010-10-29 14:06:32, Klaus Darilion wrote:
> > /branches/1.8/channels/chan_sip.c, line 12740
> > <https://reviewboard.asterisk.org/r/991/diff/1/?file=12766#file12766line12740>
> >
> >     I used a separate DB entry as adding the Path to SIP/Registry would make parsing of the astDB result more complicated. Since Russel+Stephan speed up astDB I think that should be fine.

I think we should have ONE entry per registration, not multiple. If the parsing is messy, it's time to solve that issue instead of bypassing it and adding a new entry to the soup.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/991/#review2859
-----------------------------------------------------------


On 2010-10-29 13:46:27, Klaus Darilion wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/991/
> -----------------------------------------------------------
> 
> (Updated 2010-10-29 13:46:27)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds support for the Parse header (RFC 3327). This allows to record the Path (route) of incoming REGISTER requests and then reuse the learned path on outgoing out-of-dialog requests as a pre-loaded route set.
> 
> I tried to reuse as much of existing code as possible. There are several parts where I am not sure if it is implemented nice and follow chan_sip design rules (are there any?) I will post my questions as a review to myself.
> 
> 
> This addresses bug 18223.
>     https://issues.asterisk.org/view.php?id=18223
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 293272 
>   /branches/1.8/channels/sip/include/sip.h 293272 
>   /branches/1.8/configs/sip.conf.sample 293272 
> 
> Diff: https://reviewboard.asterisk.org/r/991/diff
> 
> 
> Testing
> -------
> 
> Basic testing done (with nat=yes|no, with and without outboundproxy set for a peer, with and without Parse header, single Parse header and two Parse headers, restarting Asterisk)
> 
> 
> Thanks,
> 
> Klaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101119/88b1b79f/attachment.htm