[asterisk-dev] [Code Review] Ensure SIP responses only have one Via header

[Terry Wilson]

> On 2010-11-18 14:48:51, Olle E Johansson wrote:
> > /branches/1.4/channels/chan_sip.c, line 16814
> > <https://reviewboard.asterisk.org/r/1019/diff/1/?file=12946#file12946line16814>
> >
> >     If the via is missing, the error message is wrong. Fix error message and while you are at it, please add SIP call ID to make it easier to debug. thanks.

Will do.


> On 2010-11-18 14:48:51, Olle E Johansson wrote:
> > /branches/1.4/channels/chan_sip.c, line 16853
> > <https://reviewboard.asterisk.org/r/1019/diff/1/?file=12946#file12946line16853>
> >
> >     Please always try to add the SIP call ID to messages. Thanks.

Will do.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1019/#review2934
-----------------------------------------------------------


On 2010-11-18 14:34:42, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1019/
> -----------------------------------------------------------
> 
> (Updated 2010-11-18 14:34:42)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> 8.1.3.3 Vias
> 
>    If more than one Via header field value is present in a response, the
>    UAC SHOULD discard the message.
> 
>       The presence of additional Via header field values that precede
>       the originator of the request suggests that the message was
>       misrouted or possibly corrupted.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_sip.c 295442 
> 
> Diff: https://reviewboard.asterisk.org/r/1019/diff
> 
> 
> Testing
> -------
> 
> Used sipp to send a request with an extra via header; it was ignored. Valid responses still passed normally.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101118/b86df2ff/attachment-0001.htm