[asterisk-dev] [Code Review] ConfBridge User Announce Feature Set

[reviewboard at asterisk.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1011/#review2918
-----------------------------------------------------------



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6150>

    There is a way to specify the argument in XML.  It needs to be added here.



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6153>

    space after comma



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6154>

    remove this debug line



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6155>

    check spaces vs. tabs in here



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6152>

    You can combine these 3 checks into a single ast_test_flag()



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6151>

    check spaces vs. tabs here
    
    Also, add a space after "if", and add curly braces.
    
    (Become one with the coding guidelines)


- Russell


On 2010-11-15 17:35:58, Andrew Parisio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1011/
> -----------------------------------------------------------
> 
> (Updated 2010-11-15 17:35:58)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I copied the i and I features from meetme, as well as the same h functionality I posted in reviewboard 1009.  
> 
> I noticed I could cause a segfault if I called in from extension 1, then called in from extensions 2 and 3 at the exact same time but they had to be almost identically timed.  This didn't seem to happen in the trunk version so I think it's part of this patch.  I'm not sure if it's related to one of the locks on the bridge but I'm hoping somebody that is more knowledgeable about ConfBridge may be able to help there.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 294898 
> 
> Diff: https://reviewboard.asterisk.org/r/1011/diff
> 
> 
> Testing
> -------
> 
> ConfBridge(1,i)
> ConfBridge(1,I)
> ConfBridge(1,h(1593 at default))
> 
> 
> Thanks,
> 
> Andrew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101116/0c090319/attachment-0001.htm