[asterisk-dev] [Code Review] Prevent DTMF incorrectly triggering during SAS+CAS (CallWaiting) signalling to an FXS port

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/978/#review2883
-----------------------------------------------------------

Ship it!


Looks ok to me.  Just have a couple minor commenting items below.


trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/978/#comment6091>

    Can you give a good description for callwaitcas?  It looks like it could be:
    "TRUE if sending call waiting caller id."  However, that description does not quite fit with how it is used.



trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/978/#comment6090>

    Put this in my_callwait() as well.  my_callwait() is the sig_analog.c callback equivalent to this function.


- rmudgett


On 2010-11-04 06:49:21, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/978/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 06:49:21)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The dsp incorrectly detects a DTMF 'D' start event, during the call waiting CAS acknowledgement from a CPE device that supports SAS+CAS connected an FXS port.
> The result is the SIP call has continuous DTMF RTP packets sent to it.
> 
> This can be corrected by the FXS port pressing any DTMF button.
> 
> 
> This addresses bug 18129.
>     https://issues.asterisk.org/view.php?id=18129
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 293886 
> 
> Diff: https://reviewboard.asterisk.org/r/978/diff
> 
> 
> Testing
> -------
> 
> intial setup SIP -> FXS port (TDM800P)
> 2nd call from console -> same FXS port as above.
> 
> Call waiting beep heard, and audio resumes both directions.
> 
> 
> Thanks,
> 
> Alec
> 
>