[asterisk-dev] [Code Review] Call parking and retrieval test

[Matthew Nicholson]

> On 2010-11-02 11:43:44, Matthew Nicholson wrote:
> > /asterisk/trunk/trunk/tests/callparking_retrieval/run-test, lines 36-44
> > <https://reviewboard.asterisk.org/r/994/diff/1/?file=12797#file12797line36>
> >
> >     You should do "core stop gracefully"  before calling stop now; "stop gracefully" in 1.4.
> 
> Tilghman Lesher wrote:
>     I don't think that should make a difference.  The reason is, at this point, the test has already succeeded or failed, and we don't need the calls to exit normally.  If the calls are still up, the shutdown will simply be delayed until either the 'stop now' or the call ends.

This seems to make a difference with the code coverage tool.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/994/#review2874
-----------------------------------------------------------


On 2010-11-01 12:21:38, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/994/
> -----------------------------------------------------------
> 
> (Updated 2010-11-01 12:21:38)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a change for 1.6.2.  The patch exists, but I am attempting to work up a test to verify that it functions correctly, as a regression test.  However, the test is failing.  I think there may be something wrong with my test criteria, so I am posting it in an effort to get others to help figure this out.
> 
> 
> This addresses bug 16757.
>     https://issues.asterisk.org/view.php?id=16757
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/run-test PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userA/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userA/iax.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userB/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userB/iax.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/features.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/iax.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/994/diff
> 
> 
> Testing
> -------
> 
> This IS a test.
> 
> 
> Thanks,
> 
> Tilghman
> 
>