[asterisk-dev] [Code Review] CLI command: gtalk show settings

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/984/#review2872
-----------------------------------------------------------

Ship it!


My only comments are minor naming things ... go for it


/trunk/channels/chan_gtalk.c
<https://reviewboard.asterisk.org/r/984/#comment6064>

    I'd rather these be:
    
    static const char WHATEVER[] = "foo";
    static const int FOO = 1;



/trunk/channels/chan_gtalk.c
<https://reviewboard.asterisk.org/r/984/#comment6065>

    I wouldn't name these "default_something", since they are not the defaults, really.  They are the actual settings themselves.


- Russell


On 2010-10-26 20:50:53, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/984/
> -----------------------------------------------------------
> 
> (Updated 2010-10-26 20:50:53)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> New command to see current gtalk settings.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 293156 
>   /trunk/UPGRADE.txt 293156 
>   /trunk/channels/chan_gtalk.c 293156 
>   /trunk/configs/gtalk.conf.sample 293156 
> 
> Diff: https://reviewboard.asterisk.org/r/984/diff
> 
> 
> Testing
> -------
> 
> Local dev box.
> 
> 
> Thanks,
> 
> pabelanger
> 
>