[asterisk-dev] rhino dahdi drivers and DAHDI_VER

[Tzafrir Cohen]

Hi

While reviewing some patches to the Elastix packages of DAHDI (most of
them not submitted upstream. Why oh why?) I noticed a one that includes
include/dahdi/version.h to be installed. The changelog mentioned that it
was required for Rhino drivers to build.

I suppose that installing that file is not such a bad thing. But is the
information in it useful?

This file includes a single #define, DAHDI_VER . Its content is the
content of .version . For a released version, it is the version number.
For a branch, it is SVN-$BRANCH-$REV (e.g. SVN-branch-2.3-r9455).

The way it is used in the drivers of Rhino is something such as:

  #if DAHDI_VER >= KERNEL_VERSION(2,4,0)

This works well for a released version, I guess. But I suspect it will
completely break building with a subversion build.

So:

1. Please report bugs. Upstream. Don't keep secret fixes.
2. If you have any creative fixes that don't break anything, patches are
   welcomed.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir