[asterisk-dev] [Code Review] CDR_CSV: Add ability to disable cdr files per account code

Russell Bryant russell at digium.com
Mon May 31 16:00:53 CDT 2010



> On 2010-05-31 15:14:34, Olle E Johansson wrote:
> > /trunk/cdr/cdr_csv.c, line 124
> > <https://reviewboard.asterisk.org/r/678/diff/2/?file=10416#file10416line124>
> >
> >     There are no spaces here in my diff... Very strange.

It's saying that you have some inconsistent whitespace here.  I think you've got a space before the tab...


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/678/#review2114
-----------------------------------------------------------


On 2010-05-31 15:13:19, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/678/
> -----------------------------------------------------------
> 
> (Updated 2010-05-31 15:13:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add an option to cdr.conf to be able to disable the creation of one CDR file per account code.
> 
> (Yes, the red spaces will disappear)
> 
> 
> Diffs
> -----
> 
>   /trunk/cdr/cdr_csv.c 260800 
>   /trunk/configs/cdr.conf.sample 260800 
> 
> Diff: https://reviewboard.asterisk.org/r/678/diff
> 
> 
> Testing
> -------
> 
> Tested on internal pbx.
> 
> 
> Thanks,
> 
> Olle E
> 
>




More information about the asterisk-dev mailing list