[asterisk-dev] [Code Review] ETSI Call Waiting (libpri component)

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/569/
-----------------------------------------------------------

(Updated 2010-05-27 09:53:32.601481)


Review request for Asterisk Developers.


Changes
-------

Freshen the diff.


Summary
-------

Add the ability to announce a call to an endpoint when there are no B channels available.
A call waiting call is a SETUP message with no B channel selected.

Relevant specification: EN 300 056, EN 300 057, EN 300 058

This is based off of the team/rmudgett/aoc_event branch to get the accumulated features so far.


The Asterisk portion of this review is located in review:
https://reviewboard.asterisk.org/r/568/


Diffs (updated)
-----

  /team/rmudgett/aoc_event/libpri.h 1722 
  /team/rmudgett/aoc_event/pri.c 1722 
  /team/rmudgett/aoc_event/pri_internal.h 1722 
  /team/rmudgett/aoc_event/pri_q931.h 1722 
  /team/rmudgett/aoc_event/q931.c 1722 

Diff: https://reviewboard.asterisk.org/r/569/diff


Testing
-------

Party A ---> * ---> * ---> Party B

The link under test is between the two asterisk boxes.

1) Normal calls still work.
A calls B (Link under test is not congested.)
B answers
Call connects

2) Link congested and no B channel is released to take the call.
A calls B (Link under test is congested.  SETUP indicates no B channel.)
B answers
Call is immediately disconnected when B answers because there are no B channels.

3) Link congested and a B channel is released to take the call.
A calls B (Link under test is congested.  SETUP indicates no B channel.)
B channel is released on the link under test.
B answers
Call connects


Thanks,

rmudgett