[asterisk-dev] [Code Review] Add regular expression blacklist filtering for manager events

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/673/#review2083
-----------------------------------------------------------



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4387>

    This comment may be completely off as I am not very familiar with manager.c.  If the filter items are shallow copied from the user filter_list to the session filter_list and the user list is later freed, then is it possible that the session is still holding on to pointers to freed memory?  If this is the case, it might be simple to use ao2 structures and use a ref.



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4386>

    This only free's the filter list when the user is in the config on a reload.  If the user is removed from the config it will not be found here and this list won't get freed.


- David


On 2010-05-21 18:06:38, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2010-05-21 18:06:38)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> From the submitter:
> to allow better filtering of ami-events than configuring categories, I created an option "eventfilter" for manager-users. Events to be sent are matched against regexes specified in these options and are discarded if the regex matches (blacklisting).
> 
> 
> This addresses bug 14861.
>     https://issues.asterisk.org/view.php?id=14861
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 265171 
>   /trunk/configs/manager.conf.sample 265171 
>   /trunk/main/manager.c 265171 
> 
> Diff: https://reviewboard.asterisk.org/r/673/diff
> 
> 
> Testing
> -------
> 
> I ensured manager events are reported the same without filtering and works as expected with.
> 
> 
> Thanks,
> 
> Jeff
> 
>