[asterisk-dev] [Code Review] Set threshold for silence detection defaults 256

[paul.belanger at polybeacon.com]

> On 2010-05-21 10:35:48, Russell Bryant wrote:
> > /trunk/main/dsp.c, lines 1687-1693
> > <https://reviewboard.asterisk.org/r/670/diff/1/?file=10328#file10328line1687>
> >
> >     ast_config_destroy() here is not valid and will crash

Removed, would it not also apply to the next code block?  I'm trying to understand why it would crash.


> On 2010-05-21 10:35:48, Russell Bryant wrote:
> > /trunk/main/dsp.c, lines 216-219
> > <https://reviewboard.asterisk.org/r/670/diff/1/?file=10328#file10328line216>
> >
> >     This should be updated to use doxygen style comment syntax.  Also, I'd rather see it be a static const variable.

fixed.


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/670/#review2060
-----------------------------------------------------------


On 2010-05-20 09:28:45, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/670/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 09:28:45)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Repost of a tracker issue for dsp.c.  Created a default setting for 265, not 0.
> ---
> dant's comments:
> * Defines a default silence threshold constant set to the current default of 256
> * If the config file is not present, issues a warning saying that it will use the default silence threshold and applies the default silence threshold
> * Where the variable was set to a static value, i.e. in the event that the config existed but didn't define the variable or if it was set to an invalid value, it now uses the constant to apply the default value. 
> 
> 
> This addresses bug 15685.
>     https://issues.asterisk.org/view.php?id=15685
> 
> 
> Diffs
> -----
> 
>   /trunk/main/dsp.c 264538 
> 
> Diff: https://reviewboard.asterisk.org/r/670/diff
> 
> 
> Testing
> -------
> 
> compile testing
> 
> 
> Thanks,
> 
> pabelanger
> 
>