[asterisk-dev] [Code Review] Add regular expression blacklist filtering for manager events

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/673/#review2071
-----------------------------------------------------------


Big improvement. Not much left to fix now, afaict.


/trunk/configs/manager.conf.sample
<https://reviewboard.asterisk.org/r/673/#comment4364>

    You may want to amend this to indicate that the read categories are still used as a basis for whitelisting. You can't whitelist an event that is in a category that you have not placed in the readperms option.



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4362>

    Red spot



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4363>

    Red spot



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4361>

    Got a red spot on you there.



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4359>

    You'll need to change this to a calloc because otherwise the last element of the list will have an uninitialized "next" pointer.



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4360>

    This error message isn't necessary since ast_calloc and ast_malloc will print error messages themselves if they should fail.


- Mark


On 2010-05-21 17:08:00, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2010-05-21 17:08:00)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> From the submitter:
> to allow better filtering of ami-events than configuring categories, I created an option "eventfilter" for manager-users. Events to be sent are matched against regexes specified in these options and are discarded if the regex matches (blacklisting).
> 
> 
> This addresses bug 14861.
>     https://issues.asterisk.org/view.php?id=14861
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 265171 
>   /trunk/configs/manager.conf.sample 265171 
>   /trunk/main/manager.c 265171 
> 
> Diff: https://reviewboard.asterisk.org/r/673/diff
> 
> 
> Testing
> -------
> 
> I ensured manager events are reported the same without filtering and works as expected with.
> 
> 
> Thanks,
> 
> Jeff
> 
>