[asterisk-dev] [Code Review] Add regular expression blacklist filtering for manager events

[Russell Bryant]

> On 2010-05-21 08:01:47, Nick Lewis wrote:
> > General comment: Why a blacklist? What is the usecase? Would not a whitelist give better control i.e. if any whitelist existed all events could be blocked except those matching filters on the whitelist
> 
> Russell Bryant wrote:
>     +1
> 
> Mark Michelson wrote:
>     From the original bug report, it appears that the user didn't care about a particular event being reported, but he wanted to see other events of the same category. His solution was to blacklist the event. I'm also of the opinion that a whitelist is a good idea.

I guess it doesn't hurt to allow both, but I think whitelisting is more generally useful.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/673/#review2055
-----------------------------------------------------------


On 2010-05-20 18:42:50, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 18:42:50)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> From the submitter:
> to allow better filtering of ami-events than configuring categories, I created an option "eventfilter" for manager-users. Events to be sent are matched against regexes specified in these options and are discarded if the regex matches (blacklisting).
> 
> 
> This addresses bug 14861.
>     https://issues.asterisk.org/view.php?id=14861
> 
> 
> Diffs
> -----
> 
>   /trunk/main/manager.c 264829 
> 
> Diff: https://reviewboard.asterisk.org/r/673/diff
> 
> 
> Testing
> -------
> 
> I ensured manager events are reported the same without filtering and works as expected with.
> 
> 
> Thanks,
> 
> Jeff
> 
>