[asterisk-dev] [Code Review] Audit and reformat IAX2 definitions to match the IANA-registered values.

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/672/#review2054
-----------------------------------------------------------



/trunk/channels/iax2.h
<https://reviewboard.asterisk.org/r/672/#comment4343>

    My recommendation for how to deal with the conflict here is this:
    
    1) Request two new IE assignments from IANA for OSPTOKEN and VARIABLE.
    
    2) Modify Asterisk to use the new IE values by default when sending these IEs, and to optionally use the old values when configured to do so (probably on a per-peer basis).
    
    3) Mark the old values in Asterisk as 'deprecated', but continue to accept them indefinitely.
    
    4) Request that IANA mark 0x35 for OSPTOKEN as deprecated in favor of the new value allocated in step 1.
    
    5) Don't ever do this again :-)


- Kevin


On 2010-05-20 17:59:19, Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/672/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 17:59:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> While preparing to document some new possible IAX2 support, I cross-checked the IAX2 control subclass and information element definitions in iax2.h against the registered values in the IANA registries. This comparison was harder than it needed to be because the values in iax2.h were in decimal and not hexadecimal, so the attached patch changes that.
> 
> However, while doing this comparison, I found a mismatch that we'll need to discuss how to address. We are using 0x34 as IAX_IE_VARIABLE but in the IANA registry this value is for IAX_IE_OSPTOKEN (which we have 0x35 for). Changing this will break backwards compatibility, but as it stands, we are not compatible with the IANA-registered definitions, so something has to change or implementations written to the specifications won't interoperate with Asterisk properly.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/iax2.h 264766 
> 
> Diff: https://reviewboard.asterisk.org/r/672/diff
> 
> 
> Testing
> -------
> 
> Compile testing; there are no functional changes here yet.
> 
> 
> Thanks,
> 
> Kevin
> 
>