[asterisk-dev] [Code Review] PickupChan external tests

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/660/#review2039
-----------------------------------------------------------



/asterisk/trunk/tests/directed_pickup/run-test
<https://reviewboard.asterisk.org/r/660/#comment4329>

    I don't think you are supposed to ever use sleep while using the reactor. In this case I don't think it will technically hurt anything, but I think problems would occur if you blocked while listening for AMI events or something.


- Jeff


On 2010-05-18 16:30:08, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/660/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 16:30:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This external test exercises the PickupChan application.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/directed_pickup/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/directed_pickup/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/directed_pickup/run-test PRE-CREATION 
>   /asterisk/trunk/tests/directed_pickup/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/660/diff
> 
> 
> Testing
> -------
> 
> tested, verified it passes.
> 
> 
> Thanks,
> 
> David
> 
>