[asterisk-dev] [Code Review] New python module to facilitate monitoring manager events

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/637/#review2029
-----------------------------------------------------------

Ship it!


Looks great

- David


On 2010-05-19 13:07:29, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/637/
> -----------------------------------------------------------
> 
> (Updated 2010-05-19 13:07:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a event manager module that is designed to make monitoring for events very easy. More information of described functionality is present in the run-tests sample test file. Also, I see all the whitespace and will correct it before committing.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/client.py PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/run-test PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/starpy.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/637/diff
> 
> 
> Testing
> -------
> 
> Lots of testing has been done along the way, mostly verifying the supported event scenarios work as expected. Currently the only event test present in the sample test module is monitoring the response to a ping event.
> 
> 
> Thanks,
> 
> Jeff
> 
>