[asterisk-dev] [Code Review] High Resolution Call Time for Billsec and Duration

[Brad Latus]

> On 2010-05-10 16:21:42, Mark Michelson wrote:
> > /trunk/cdr/cdr_sqlite.c, line 54
> > <https://reviewboard.asterisk.org/r/461/diff/12/?file=8927#file8927line54>
> >
> >     Since this is being defined to 0, it means that all the code you added in this file is basically a giant comment. Why not control this with a configuration option like the rest of the CDR modules?

I am keeping with the 'style' of this cdr module.
The module is already deprecated by the 'cdr_sqlite3_custom' module, this was just added for completeness.


> On 2010-05-10 16:21:42, Mark Michelson wrote:
> > /trunk/addons/cdr_mysql.c, line 302
> > <https://reviewboard.asterisk.org/r/461/diff/12/?file=8923#file8923line302>
> >
> >     Put a space after the final comma.

can do.


- Brad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/461/#review1992
-----------------------------------------------------------


On 2010-03-31 14:03:10, Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/461/
> -----------------------------------------------------------
> 
> (Updated 2010-03-31 14:03:10)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This allows for the showing of the accurate times for billable time and call duration.
> Adds new flag to CDR function 'f' for the above fields.
> 
> This came about by bug #16559 and I thought i'd take a go at making it happen.
> 
> We can drop a few of the modules for ones we want to depreciate like sql-lite / odbc (in favour of sql-lite3 / adaptive_odbc)
> 
> 
> This addresses bug 16559.
>     https://issues.asterisk.org/view.php?id=16559
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 253708 
>   /trunk/UPGRADE.txt 253708 
>   /trunk/addons/cdr_mysql.c 253708 
>   /trunk/cdr/cdr_adaptive_odbc.c 253708 
>   /trunk/cdr/cdr_odbc.c 253708 
>   /trunk/cdr/cdr_pgsql.c 253708 
>   /trunk/cdr/cdr_sqlite.c 253708 
>   /trunk/cdr/cdr_tds.c 253708 
>   /trunk/configs/cdr_custom.conf.sample 253708 
>   /trunk/configs/cdr_odbc.conf.sample 253708 
>   /trunk/configs/cdr_sqlite3_custom.conf.sample 253708 
>   /trunk/configs/cdr_syslog.conf.sample 253708 
>   /trunk/configs/cdr_tds.conf.sample 253708 
>   /trunk/funcs/func_cdr.c 253708 
> 
> Diff: https://reviewboard.asterisk.org/r/461/diff
> 
> 
> Testing
> -------
> 
> Compile test + Basic tests with cdr_custom.
> Now tested with postgres and mysql modules.
> Works fine with cdr_odbc and cdr_adaptive_odbc.
> I now consider testing complete..
> 
> 
> Thanks,
> 
> Brad
> 
>