[asterisk-dev] [Code Review] update live_ast for testsuite and changes for new asterisk.conf.samples file.

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/648/#review1970
-----------------------------------------------------------


You basically hard-wire the system layout. IIRC that layout is different in other OSes.

It also means that you have to re-configure the system before switching between a live install and a real one.

What's wrong with the current usage of DESTDIR?

The reason I have separate 'install' and 'samples' target is because you normally use 'samples' once (and optionally tweak its results later) whereas 'install' is the main target you use (build and install), and is harmless to the configuration.

In fact, if you merely rebuilt a simple module, you can normally get away with not restarting asterisk and merely unload and reload the new module. This is a much faster testing cycle.


/trunk/contrib/scripts/live_ast
<https://reviewboard.asterisk.org/r/648/#comment4205>

    This assumes 'BASE_DIR' has no spaces in it.


- Tzafrir


On 2010-05-04 21:08:25, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/648/
> -----------------------------------------------------------
> 
> (Updated 2010-05-04 21:08:25)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Using live_ast, I've create a new option 'testsuite'; creating a default asterisk install as a non-root. 
> 
> The major difference from the existing script, 'samples' disables some Asterisk functionality by default. Rather then changing it, I've created a new option. I have also commented out 'LIVE_AST_FOR_SYSTEM' logic, as I don't believe it is valid anymore; by default we create a non-root run directory.
> 
> I've also removed $DESTDIR and editing asterisk.conf, we now set the variables using ./configure.
> 
> 
> This addresses bug 17165.
>     https://issues.asterisk.org/view.php?id=17165
> 
> 
> Diffs
> -----
> 
>   /trunk/contrib/scripts/live_ast 261223 
> 
> Diff: https://reviewboard.asterisk.org/r/648/diff
> 
> 
> Testing
> -------
> 
> Local developers and QA boxes.
> 
> 
> Thanks,
> 
> pabelanger
> 
>