[asterisk-dev] [Code Review] Parsing of reg->username containing @domain

[Nick Lewis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/628/
-----------------------------------------------------------

(Updated 2010-05-05 05:46:44.926081)


Review request for Asterisk Developers and David Vossel.


Changes
-------

Restores calculation of argc value in app.c:__ast_app_separate_args() while continuing to initialize all elements


Summary
-------

reg->username is parsed for each registration refresh rather than once on sip reload. A previously committed change that addressed this was reverted because it did not cater for registration strings that contained a peer name in the host field. This change does. 


This addresses bug 14331.
    https://issues.asterisk.org/view.php?id=14331


Diffs (updated)
-----

  trunk/channels/chan_sip.c 258227 
  trunk/channels/sip/config_parser.c 258227 
  trunk/channels/sip/include/sip.h 258228 
  trunk/main/app.c 258227 

Diff: https://reviewboard.asterisk.org/r/628/diff


Testing
-------

Passes a new unit test for parsing usernames containing domains. Passes existing unit tests. Passes peername functional test with sip.conf snippet

[general]
register=nick at quirk
[quirk]
fromdomain=10.10.235.48


Thanks,

Nick