[asterisk-dev] [Code Review] New python module to facilitate monitoring manager events

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/637/#review1960
-----------------------------------------------------------



/asterisk/trunk/tests/ami-monitor/client.py
<https://reviewboard.asterisk.org/r/637/#comment4191>

    This should be in lib/python if it is going to be used by other tests.
    
    Also, some API documentation for this class would be good to have.



/asterisk/trunk/tests/ami-monitor/client.py
<https://reviewboard.asterisk.org/r/637/#comment4192>

    clean up trailing whitespace



/asterisk/trunk/tests/ami-monitor/run-test
<https://reviewboard.asterisk.org/r/637/#comment4193>

    Why all the commented out code?  If they are to serve as examples, they should go in the documentation for the watcher class


- Russell


On 2010-04-29 19:10:14, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/637/
> -----------------------------------------------------------
> 
> (Updated 2010-04-29 19:10:14)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a event manager module that is designed to make monitoring for events very easy. More information of described functionality is present in the run-tests sample test file. Also, I see all the whitespace and will correct it before committing.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/ami-monitor/client.py PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/run-test PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/starpy.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/637/diff
> 
> 
> Testing
> -------
> 
> Lots of testing has been done along the way, mostly verifying the supported event scenarios work as expected. Currently the only event test present in the sample test module is monitoring the response to a ping event.
> 
> 
> Thanks,
> 
> Jeff
> 
>