[asterisk-dev] [Code Review] ETSI Message Waiting Indication (MWI) (libpri component)

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/600/
-----------------------------------------------------------

(Updated 2010-03-31 11:41:55.335739)


Review request for Asterisk Developers.


Summary
-------

Add the ability to report waiting messages to ISDN endpoints (phones).

Relevant specification: EN 300 650 and EN 300 745

This is based off of the team/rmudgett/mcid branch to get the
accumulated features so far.

The Asterisk portion of this review is locatged in review:
https://reviewboard.asterisk.org/r/599/


Diffs
-----

  /team/rmudgett/mcid/Makefile 1571 
  /team/rmudgett/mcid/libpri.h 1571 
  /team/rmudgett/mcid/pri.c 1571 
  /team/rmudgett/mcid/pri_facility.c 1571 
  /team/rmudgett/mcid/pri_internal.h 1571 
  /team/rmudgett/mcid/rose.h 1571 
  /team/rmudgett/mcid/rose.c 1571 
  /team/rmudgett/mcid/rose_etsi_mwi.c PRE-CREATION 
  /team/rmudgett/mcid/rose_internal.h 1571 
  /team/rmudgett/mcid/rose_qsig_mwi.c 1571 
  /team/rmudgett/mcid/rosetest.c 1571 

Diff: https://reviewboard.asterisk.org/r/600/diff


Testing (updated)
-------

1) Setup app_voicemail
2) Left messages in various voice mail contexts
3) Retrieved messages

Verified that the MWIIndication message reported the expected number of waiting messages.
Also verified that the MWIIndication message is reported when Asterisk is started.

Also updated the rosetest encode/decode unit test.


Thanks,

rmudgett