[asterisk-dev] [Code Review] External Test Suite Additions: Asterisk instances in Python, AMI Login test, and IAX2 + FastAGI test

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/598/#review1777
-----------------------------------------------------------

Ship it!


Nice stuff. If the tests pass, I say it's good to go.

- Mark


On 2010-03-30 15:23:43, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/598/
> -----------------------------------------------------------
> 
> (Updated 2010-03-30 15:23:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> New test suite components:
> 
> 
> 1) lib/python/asterisk/asterisk.py
> 
> This module allows you to create multiple instances of Asterisk from within a test implemented in python.
> 
> 
> 2) tests/ami-login
> 
> This is a test implemented in python that creates a single Asterisk() instance and verifies that it can log in to the AMI.  It is a simple test to demonstrate Asterisk(), as well as basic usage of starpy for AMI integration.
> 
> 
> 3) tests/iax-basic-call
> 
> This is a test implemented in python that creates two Asterisk() instances.  It also is a simple demonstration of using starpy, but in this case for FastAGI connections.  It verifies that an IAX2 call can be made between two instances of Asterisk with a successful FastAGI connection on each end.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py PRE-CREATION 
>   /asterisk/trunk/tests/ami-login/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-login/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-login/run-test PRE-CREATION 
>   /asterisk/trunk/tests/ami-login/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/configs2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/configs2/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/configs2/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/run-test PRE-CREATION 
>   /asterisk/trunk/tests/iax-call-basic/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 159 
> 
> Diff: https://reviewboard.asterisk.org/r/598/diff
> 
> 
> Testing
> -------
> 
> I have run these tests in the test suite many times on Asterisk trunk.  I intend for it to apply to all versions, so I still need to try those.  I also need to produce documentation for the asterisk.py module.
> 
> 
> Thanks,
> 
> Russell
> 
>