[asterisk-dev] [Code Review] High Resolution Call Time for Billsec and Duration

Brad Latus snuffy22 at gmail.com
Thu Mar 25 17:11:08 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/461/
-----------------------------------------------------------

(Updated 2010-03-25 17:11:08.232558)


Review request for Asterisk Developers.


Changes
-------

Updated with a minor change for func_cdr.. 

using sqlite3_custom module with my example config will cause error, this is known and will be fixed by the maintainer of that code.


Summary
-------

This allows for the showing of the accurate times for billable time and call duration.
Adds new flag to CDR function 'f' for the above fields.

This came about by bug #16559 and I thought i'd take a go at making it happen.

We can drop a few of the modules for ones we want to depreciate like sql-lite / odbc (in favour of sql-lite3 / adaptive_odbc)


This addresses bug 16559.
    https://issues.asterisk.org/view.php?id=16559


Diffs (updated)
-----

  /trunk/CHANGES 253708 
  /trunk/UPGRADE.txt 253708 
  /trunk/addons/cdr_mysql.c 253708 
  /trunk/cdr/cdr_adaptive_odbc.c 253708 
  /trunk/cdr/cdr_odbc.c 253708 
  /trunk/cdr/cdr_pgsql.c 253708 
  /trunk/cdr/cdr_sqlite.c 253708 
  /trunk/cdr/cdr_tds.c 253708 
  /trunk/configs/cdr_custom.conf.sample 253708 
  /trunk/configs/cdr_odbc.conf.sample 253708 
  /trunk/configs/cdr_sqlite3_custom.conf.sample 253708 
  /trunk/configs/cdr_syslog.conf.sample 253708 
  /trunk/configs/cdr_tds.conf.sample 253708 
  /trunk/funcs/func_cdr.c 253708 

Diff: https://reviewboard.asterisk.org/r/461/diff


Testing
-------

Compile test + Basic tests with cdr_custom.
Now tested with postgres and mysql modules.


Thanks,

Brad




More information about the asterisk-dev mailing list