[asterisk-dev] [Code Review] ACL unit tests

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/532/#review1758
-----------------------------------------------------------

Ship it!



/trunk/tests/test_acl.c
<https://reviewboard.asterisk.org/r/532/#comment3838>

    Add the ASTERISK_FILE_VERSION macro after this line



/trunk/tests/test_acl.c
<https://reviewboard.asterisk.org/r/532/#comment3839>

    You could just remember that a case failed and continue trying the rest of your test cases before returning failure.



/trunk/tests/test_acl.c
<https://reviewboard.asterisk.org/r/532/#comment3840>

    Move the { to the next line



/trunk/tests/test_acl.c
<https://reviewboard.asterisk.org/r/532/#comment3841>

    red block of death


- Russell


On 2010-02-25 16:53:23, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/532/
> -----------------------------------------------------------
> 
> (Updated 2010-02-25 16:53:23)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> There are two unit tests contained here.
> 
> 1. "Invalid ACL" This attempts to read a bunch of badly formatted ACL entries and add them to a host access rule. The goal of this test is to be sure that all invalid entries are rejected as they should be.
> 
> 2. "ACL" This sets up four ACLs. One is a permit all, one is a deny all, and the other two have specific rules about which subnets are allowed and which are not. Then a set of test addresses is used to determine whether we would allow those addresses to access us when each ACL is applied. This test, by the way, was what resulted in AST-2010-003's creation.
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_acl.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/532/diff
> 
> 
> Testing
> -------
> 
> Both tests run and pass.
> 
> 
> Thanks,
> 
> Mark
> 
>