[asterisk-dev] [Code Review] Build system: allow certain definitions to only be selected explicitly (for UNSUPPORTED_MODULES)

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/506/#review1755
-----------------------------------------------------------

Ship it!


This looks fine, the only change I'd request is that the references in menuselect are 'enabling' a module, not 'setting' it. Please change 'explicitly_set_only' to 'explicit_enable_only'. Thanks.

- Kevin


On 2010-02-15 19:59:31, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/506/
> -----------------------------------------------------------
> 
> (Updated 2010-02-15 19:59:31)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, module dependencies are automatically resolved, but in one case, I'd like the dependency to need to be selected only explicitly, because I'd prefer people using unsupported modules to have to consciously make that choice.
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect.h 715 
>   /trunk/menuselect.c 715 
> 
> Diff: https://reviewboard.asterisk.org/r/506/diff
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> 
> Thanks,
> 
> Tilghman
> 
>