[asterisk-dev] [Bamboo] Asterisk - trunk - OpenBSD build 99 has FAILED. Change made by Kevin P. Fleming and Leif Madsen

[Bamboo]

-------------- next part --------------
-----------------------------------------------------------
AST-TRUNKOPENBSD-99 failed.
-----------------------------------------------------------
This build occured because it is a dependant of AST-TRUNK-317.
No failed tests found, a possible compilation error.

http://bamboo.asterisk.org/browse/AST-TRUNKOPENBSD-99/        


--------------
Code Changes
--------------
Kevin P. Fleming (254450):

>Improve handling of T.38 re-INVITEs that arrive before a T.38-capable
>application is executing on a channel.
>
>This patch addresses an issue found during working with end-users
>using res_fax. If an incoming call is answered in the dialplan, or
>jumps to the 'fax' extension due to reception of a CNG tone (with
>faxdetect enabled), and then the remote endpoint sends a T.38
>re-INVITE, it is possible for the channel's T.38 state to be
>'T38_STATE_NEGOTIATING' when the application starts up. Unfortunately,
>even if the application wants to use T.38, it can't respond to the
>peer's negotiation request, because the AST_CONTROL_T38_PARAMETERS
>control frame that chan_sip sent originally has been lost, and the
>application needs the content of that frame to be able to formulate a
>reply.
>
>This patch adds a new 'request' type to AST_CONTROL_T38_PARAMETERS,
>AST_T38_REQUEST_PARMS. If the application sends this request, chan_sip
>will re-send the original control frame (with
>AST_T38_REQUEST_NEGOTIATE as the request type), and the application
>can respond as normal. If this occurs within the five second timeout
>in chan_sip, the automatic cancellation of the peer reinvite will be
>stopped, and the application will 'own' the negotiation process from
>that point onwards.
>
>This also improves the code path in chan_sip to allow sip_indicate(),
>when called for AST_CONTROL_T38_PARAMETERS, to be able to return a
>non-zero response, which should have been in place before since the
>control frame *can* fail to be processed properly. It also modifies
>ast_indicate() to return whatever result the channel driver returned
>for this control frame, rather than converting all non-zero results
>into '-1'. Finally, the new request type intentionally returns a
>positive value, so that an application that sends
>AST_T38_REQUEST_PARMS can know for certain whether the channel driver
>accepted it and will be replying with a control frame of its own, or
>whether it was ignored (if the sip_indicate()/ast_indicate() path had
>properly supported failure responses before, this would not be
>necessary).
>
>This patch also modifies res_fax to take advantage of the new request.
>
>In addition, this patch makes sip_t38_abort() actually lock the
>private structure before doing its work... bad programmer, no donut.
>
>This patch also enhances chan_sip's 'faxdetect' support to allow
>triggering on T.38 re-INVITEs received as well as CNG tone detection.
>
>Review: https://reviewboard.asterisk.org/r/556/
>
>

Leif Madsen (254446):

>handle_speechset has 4 arguments.
>
>Update code to reflect that handle_speechset has 4 arguments.
>
>(closes issue #17093)
>Reported by: gpatri
>Patches: 
>      res_agi.patch uploaded by gpatri (license 1014)
>Tested by: pabelanger, mmichelson


--------------
Error Summary
--------------
   build_tools/make_version[79]: {print $2;}: not found
   build_tools/make_version[79]: URL: not found
   svn: Write error: Broken pipe
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   /bin/sh: /bin/sh: - : unknown option
   Package gtk+-2.0 was not found in the pkg-config search path
   Package gtk+-2.0 was not found in the pkg-config search path
   menuselect.o(.text+0x3123): In function `generate_makeopts_file':
   /srv/bamboo/xml-data/build-dir/AST-TRUNKOPENBSD/menuselect/menuselect.c:1215: warning: strcpy() is almost always misused, please use strlcpy()
   mxml/libmxml.a(mxml-file.o)(.text+0x2669): In function `mxml_write_node':
   /srv/bamboo/xml-data/build-dir/AST-TRUNKOPENBSD/menuselect/mxml/mxml-file.c:2664: warning: sprintf() is often misused, please use snprintf()
   /usr/lib/libstdc++.so.47.0: warning: strcpy() is almost always misused, please use strlcpy()
   /usr/lib/libstdc++.so.47.0: warning: strcat() is almost always misused, please use strlcat()
   utils.o(.text+0xfb1): In function `__ast_string_field_ptr_build_va':
   /srv/bamboo/xml-data/build-dir/AST-TRUNKOPENBSD/main/utils.c:1724: warning: vsprintf() is often misused, please use vsnprintf()
   app.o(.text+0x13ac): In function `ast_app_group_set_channel':
   /srv/bamboo/xml-data/build-dir/AST-TRUNKOPENBSD/main/app.c:1056: warning: strcpy() is almost always misused, please use strlcpy()
   app.o(.text+0xc3f): In function `ast_control_streamfile':
   /srv/bamboo/xml-data/build-dir/AST-TRUNKOPENBSD/main/app.c:546: warning: strcat() is almost always misused, please use strlcat()
   ast_expr2.o(.text+0x2dd7): In function `op_eq':
   /srv/bamboo/xml-data/build-dir/AST-TRUNKOPENBSD/main/ast_expr2.y:635: warning: sprintf() is often misused, please use snprintf()
   /usr/bin/ld: final link failed: No space left on device
   collect2: ld returned 1 exit status
   gmake[1]: *** [asterisk] Error 1
   gmake: *** [main] Error 2


--
This message is automatically generated by Atlassian Bamboo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20100325/490c5e23/attachment-0001.htm