[asterisk-dev] [Code Review] Allow configuration of minsecs and nextaftercmd per mailbox

[Russell Bryant]

> On 2010-03-23 11:30:15, Russell Bryant wrote:
> > /trunk/apps/app_voicemail.c, line 9854
> > <https://reviewboard.asterisk.org/r/555/diff/4/?file=8764#file8764line9854>
> >
> >     Does this still need to be checked globally?  Are the global flags not inherited by the vmu objects?  I would expect it to be inherited, and then optionally have a mailbox specific setting override it.
> 
> Jeff Peeler wrote:
>     The option is not inherited.

It should be.  That's how I would expect every option in Asterisk to behave that is both a [general] and specific option.  The value set in the general section should only be applicable if it was not specified for the particular entry at all.  Otherwise, whatever was specified for that entry should take effect.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/555/#review1722
-----------------------------------------------------------


On 2010-03-23 18:30:37, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/555/
> -----------------------------------------------------------
> 
> (Updated 2010-03-23 18:30:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Make this work in voicemail.conf:
> 
> [default]
> 1234 => 4242,Example Mailbox,imapuser at localhost,,minsecs=5|nextaftercmd=yes
> 
> 
> This addresses bug 16864.
>     https://issues.asterisk.org/view.php?id=16864
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 254162 
> 
> Diff: https://reviewboard.asterisk.org/r/555/diff
> 
> 
> Testing
> -------
> 
> Tested both options to ensure they were respected and have also created a unit test that checks to see if the vm_user struct is populated correctly (I guess it'll protect against accidental deletions or typos).
> 
> 
> Thanks,
> 
> Jeff
> 
>