[asterisk-dev] [Code Review] ETSI Malicious Call ID (Asterisk component)

[rmudgett at digium.com]

> On 2010-03-23 14:40:26, Russell Bryant wrote:
> > /trunk/mcid_events.txt, lines 1-12
> > <https://reviewboard.asterisk.org/r/576/diff/1/?file=8849#file8849line1>
> >
> >     We need to make sure that we make manager headers as consistent as possible with previously implemented manager events.  The CallerID headers, for example, are a syntax that I have not seen before that I recall.  I know that CallerIDName and CallerIDNum are used a good bit.  Take a look at some other manager events to see what would be best.

I did look at how other events were done to find out how to generate events.  The headers and data that other events provide is simple and done with a hardcoded printf string.  The MCID event message string is built by code because I have regular data available.  Also, the subaddress headers do not always appear in the event because it is not always part of the party ID.  However, for the MCID events here I could eliminate the '/' and the headers could be reduced to look like other events:

CallerIDPres
CallerIDNum
CallerIDton
CallerIDName
CallerIDSubaddr
CallerIDSubaddrType
CallerIDSubaddrOdd
ConnectedIDPres
ConnectedIDNum
ConnectedIDton
ConnectedIDSubaddr
ConnectedIDSubaddrType
ConnectedIDSubaddrOdd

Is this more what you had in mind?


FYI, other events use:
CallerIDNum, CallerIDnum, CallerID, CallerID1, CallerID2
CallerIDName, CallerIDname,
CallerIDani
CallerIDrdnis
CallerIDdnid
CID-CallingPres

For the AOC events in another review I really need a hierarchical format to indicate arrays and structured data.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/576/#review1728
-----------------------------------------------------------


On 2010-03-22 11:59:09, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/576/
> -----------------------------------------------------------
> 
> (Updated 2010-03-22 11:59:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the ability to report malicious callers as an AMI event in the call event class.
> 
> Relevant specification: EN 300 180
> 
> The libpri portion of this review is located in review:
> https://reviewboard.asterisk.org/r/575/
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 253711 
>   /trunk/channels/sig_pri.h 253711 
>   /trunk/channels/sig_pri.c 253711 
>   /trunk/configure.ac 253711 
>   /trunk/include/asterisk/channel.h 253711 
>   /trunk/main/channel.c 253711 
>   /trunk/mcid_events.txt PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/576/diff
> 
> 
> Testing
> -------
> 
> Report call while connected.
> Report call after caller hangs up.
> 
> Comments about the format of the MCID events are also requested.
> The following is a sample of the events generated:
> 
> This event was generated when the caller was connected.
> 
> Event: MCID
> Privilege: call,all
> Channel: DAHDI/i2/400-d
> UniqueID: 1268949315.44
> CallerID/Presentation: 0 (Presentation Allowed, Not Screened)
> CallerID/Number: 200
> CallerID/TON: 33
> CallerID/Name:
> CallerID/Subaddress: 54321
> CallerID/Subaddress/Type: 2
> CallerID/Subaddress/Odd: 1
> ConnectedID/Presentation: 0 (Presentation Allowed, Not Screened)
> ConnectedID/Number: 400
> ConnectedID/TON: 0
> ConnectedID/Name:
> 
> This event was generated after the caller disconnected and before the
> answerer hung up.  Since the Asterisk channel has already been destroyed
> we have to rely on information that libpri can supply.  This information
> may be incomplete if the upper layer (Asterisk) redacted some caller
> information because it was restricted.
> 
> Event: MCID
> Privilege: call,all
> CallerID/Presentation: 0 (Presentation Allowed, Not Screened)
> CallerID/Number: 200
> CallerID/TON: 33
> CallerID/Name:
> CallerID/Subaddress: 54321
> CallerID/Subaddress/Type: 2
> CallerID/Subaddress/Odd: 1
> ConnectedID/Presentation: 0 (Presentation Allowed, Not Screened)
> ConnectedID/Number: 400
> ConnectedID/TON: 0
> ConnectedID/Name:
> 
> 
> Thanks,
> 
> rmudgett
> 
>