[asterisk-dev] [Code Review] Rework CDR API Internals to Prevent Loss of CDR Records

[Russell Bryant]

> On 2010-02-26 10:08:27, Mark Michelson wrote:
> > Now I looked at the backends too.

Thanks for the review!


> On 2010-02-26 10:08:27, Mark Michelson wrote:
> > /trunk/cdr/cdr_adaptive_odbc.c, lines 168-169
> > <https://reviewboard.asterisk.org/r/531/diff/3/?file=8399#file8399line168>
> >
> >     Add code here to handle a potential NULL return from ast_cdr_register_sink

done


> On 2010-02-26 10:08:27, Mark Michelson wrote:
> > /trunk/cdr/cdr_custom.c, lines 131-132
> > <https://reviewboard.asterisk.org/r/531/diff/3/?file=8400#file8400line131>
> >
> >     Handle a potential NULL return here.

done


> On 2010-02-26 10:08:27, Mark Michelson wrote:
> > /trunk/cdr/cdr_syslog.c, lines 210-211
> > <https://reviewboard.asterisk.org/r/531/diff/3/?file=8403#file8403line210>
> >
> >     Handle a potential NULL return here.

done


> On 2010-02-26 10:08:27, Mark Michelson wrote:
> > /trunk/include/asterisk/cdr.h, lines 203-211
> > <https://reviewboard.asterisk.org/r/531/diff/3/?file=8405#file8405line203>
> >
> >     I noticed a trend while looking at how this function is used. First, the return value is never actually inspected, and second, this function is followed up every single time by setting the backend to NULL.
> >     
> >     I think that given these two facts, it may be worthwhile to change the return type here to be a void pointer (or ast_cdr_backend pointer, either way) and always return NULL. That way, you can use:
> >     
> >     backend = ast_cdr_unregister_sink(backend);

Good suggestion, done


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/531/#review1609
-----------------------------------------------------------


On 2010-03-23 13:41:09, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/531/
> -----------------------------------------------------------
> 
> (Updated 2010-03-23 13:41:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This code comes from the team/russell/cdr-q branch.  It is something I did on a couple of flights this week.
> 
> The current CDR implementation in Asterisk does nothing to ensure that every CDR record is successfully logged to configured logging destinations.  A single attempt is made to log a record.  If for some reason it fails, such as connectivity to a database being temporarily disrupted, then the records are lost.  Obviously, this is very bad in many cases where these records are used for things like billing.
> 
> The primary purpose behind these changes is to ensure that every record is successfully logged to every destination that has been configured.  If posting a CDR fails, it will be queued up for a retry later.
> 
> A new method has been added for backends to register callbacks for receiving CDR records.  For CDR modules that allow posting CDRs to multiple destinations, such as multiple DB tables or multiple text files, they now make a registration into the core for every destination.  That way, the success or failure of the attempt to each destination can be tracked.  All backends that need it have been updated to operate this way.
> 
> main/cdr.c has also been updated to use more modern Asterisk APIs.  It has also been updated with various other bits of code cleanup.
> 
> One side effect of these changes is that the code that previously implemented the batch mode has been completely removed, as that code is now deprecated.  The biggest benefit from batch mode was handling CDR posting asynchronously from channel threads.  In this code, that is the only behavior that exists.
> 
> 
> This addresses bug 17042.
>     https://issues.asterisk.org/view.php?id=17042
> 
> 
> Diffs
> -----
> 
>   /trunk/UPGRADE.txt 249057 
>   /trunk/cdr/cdr_adaptive_odbc.c 249058 
>   /trunk/cdr/cdr_custom.c 249058 
>   /trunk/cdr/cdr_odbc.c 249058 
>   /trunk/cdr/cdr_radius.c 249058 
>   /trunk/cdr/cdr_syslog.c 249058 
>   /trunk/configs/cdr.conf.sample 249057 
>   /trunk/include/asterisk/cdr.h 249057 
>   /trunk/main/asterisk.c 249057 
>   /trunk/main/cdr.c 249057 
>   /trunk/main/features.c 249057 
>   /trunk/main/manager.c 249057 
> 
> Diff: https://reviewboard.asterisk.org/r/531/diff
> 
> 
> Testing
> -------
> 
> I have done some manual testing.  However, before I consider this done, I would like to implement some automated tests, as well as touch on more backends than what I have tested so far.
> 
> I configured cdr_custom to log CDRs to multiple files.  I made calls and verified that records were logged successfully.  I made some modifications on disk such that attempts to log to one file would fail, while the other would continue to succeed.  I made more calls and verified that the CDR queue grew for the specific file that had failures.  I fixed the problem and continued making calls.  I verified that all previously failed CDRs were posted and that both files were in sync with the number of CDRs that they had.
> 
> 
> Thanks,
> 
> Russell
> 
>