[asterisk-dev] [Code Review] Change native bridging to switch to generic bridging for accurate timing in cases that need it

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/577/#review1725
-----------------------------------------------------------

Ship it!


This change looks sane to me.

- Russell


On 2010-03-23 12:42:44, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/577/
> -----------------------------------------------------------
> 
> (Updated 2010-03-23 12:42:44)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This changes native bridging to break one millisecond early so that the more accurate timeval calculations done in the generic bridge can be performed using the bridge config. Currently the time between exiting native bridging slightly late can sometimes cause a large enough discrepancy for warnings to be missed.
> 
> 
> This addresses bug 15815.
>     https://issues.asterisk.org/view.php?id=15815
> 
> 
> Diffs
> -----
> 
>   /trunk/main/channel.c 253978 
> 
> Diff: https://reviewboard.asterisk.org/r/577/diff
> 
> 
> Testing
> -------
> 
> I've tested a plain generic bridge, a generic bridge with warnings, a native bridge with warnings, and a plain native bridge.
> 
> 
> Thanks,
> 
> Jeff
> 
>