[asterisk-dev] [Code Review] Change per-file debug and verbose levels to be per-module, the way users expect them to work.

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/574/
-----------------------------------------------------------

(Updated 2010-03-22 11:33:34.706186)


Review request for Asterisk Developers.


Summary (updated)
-------

'core set debug' and 'core set verbose' can optionally change the level for a specific filename; however, this is actually for a specific source file name, not the module that source file is included in. With examples like chan_sip, chan_iax2, chan_misdn and others consisting of multiple source files, this will not lead to the behavior that users expect. If they want to set the debug level for chan_sip, they want it set for all of chan_sip, and not to have to also set it for reqresp_parser and other files that comprise the chan_sip module.

This patch changes this functionality to be module-name based instead of file-name based.

To make this work, some Makefile modifications were required to ensure that the AST_MODULE definition is present in each object file produced for each module as well. 


Diffs
-----

  /trunk/Makefile.moddir_rules 253530 
  /trunk/channels/Makefile 253530 
  /trunk/codecs/Makefile 253530 
  /trunk/include/asterisk/logger.h 253530 
  /trunk/include/asterisk/options.h 253530 
  /trunk/main/Makefile 253530 
  /trunk/main/cli.c 253530 
  /trunk/pbx/Makefile 253530 
  /trunk/res/Makefile 253530 

Diff: https://reviewboard.asterisk.org/r/574/diff


Testing
-------

Compile testing, and basic CLI sanity checking.


Thanks,

Kevin