[asterisk-dev] [Code Review] Mute / Unmute manager commands for MixMonitor

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/487/#review1707
-----------------------------------------------------------


I would patch a fresh checkout of trunk with http://pastebin.ca/1845714 (which is just your current patch without all of the extraneous whitespace changes) and then address the issues below.


trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/487/#comment3787>

    You're leaking a channel reference in case of an error.  You need to ast_channel_unref before you return here.



trunk/main/audiohook.c
<https://reviewboard.asterisk.org/r/487/#comment3788>

    Since you are using ast_frame_clear() now, you don't actually need these pointers anymore.  Make sure you test compile with:
    
        ./configure --enable-dev-mode
        make
    
    Which will cause the compile to error out in these cases.


- Sean


On 2010-02-24 11:05:21, Julian Lyndon-Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/487/
> -----------------------------------------------------------
> 
> (Updated 2010-02-24 11:05:21)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> For PCI-DSS compliance we are not allowed to record a credit card number in a MixMonitor file. However, we must record all conversations ....
> 
> I have added a new feature to audiohooks so that you can mute either read / write or both types of frames - this allows for MixMonitor to mute either side of the conversation without affecting the conversation itself.
> 
> MixMonitor now has two manager commands
> 
> 1) manager show command MuteMixMonitor
> Action: MuteMixMonitor
> Synopsis: Mute a channel in MixMonitor
> Privilege: <none>
> Description: Mutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to mute.
>   Direction: Which part to mute. read|write|both (from channel|to channel|both channels).
> 
> 2) manager show command unMuteMixMonitor
> Action: unMuteMixMonitor
> Synopsis: unMute a channel in MixMonitor
> Privilege: <none>
> Description: unMutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to unmute.
>   Direction: Which part to unmute. read|write|both (from channel|to channel|both channels).
> 
> 
> This addresses bug 16740.
>     https://issues.asterisk.org/view.php?id=16740
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_mixmonitor.c 244767 
>   trunk/include/asterisk/audiohook.h 244767 
>   trunk/include/asterisk/frame.h 244767 
>   trunk/main/audiohook.c 244767 
>   trunk/main/frame.c 244767 
>   trunk/res/res_mutestream.c 244767 
> 
> Diff: https://reviewboard.asterisk.org/r/487/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.4 : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
> Tested on trunk : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
> 
> 
> Thanks,
> 
> Julian
> 
>